Yes it occurs in a standard SVN installation. This is done by using svn
hooks which is precisely what we have.  Anyone can change the output of
the svn log command (ie: no change to svn source is required).  So yes I
definiately consider this standard.  It isn't considered "default"
behaviour, but I would definitely describe it as standard.

It is my opinion that this fix should be in the main repo. Individual
users/companies should not have to maintain their own copy of it. It
makes synchronizing changes between the main repo and all others an
extra chore that shouldn't be necessary.

We should also take note that Subversion does not make any guarantees
regarding the format of the svn log author output. They could very well
change this "default" behaviour to something that doesn't match what is
currently being parsed. So the fix I am proposing makes the code base
more robust, which is always a good thing.

---
Todd Thiessen
 

> -----Original Message-----
> From: Mark Struberg [mailto:strub...@yahoo.de] 
> Sent: Thursday, January 15, 2009 10:30 AM
> To: scm-dev@maven.apache.org
> Subject: RE: SCM plugin project
> 
> Humm, so this SVN behaviour cannot occur in a standard SVN 
> installation? Or can this also be achieved by anyone? If not, 
> there is imho little chance of getting your changes into the 
> upstream repo.
> 
> Do you have a parent pom for your projects? Have you tried to 
> override the dependency on maven-scm-provider-svnexe for your 
> build to a locally patched version via <dependencyManagement> ? 
> 
> I assume you have something like archiva, mavenproxy or nexus 
> setup and also have a company-internal plugin repository, isn't?
> 
> So you could easily make the release process work for your 
> company without having to release your changes to the public repo.
> 
> LieGrue,
> strub
> 
> 
> --- Todd Thiessen <thies...@nortel.com> schrieb am Do, 15.1.2009:
> 
> > Von: Todd Thiessen <thies...@nortel.com>
> > Betreff: RE: SCM plugin project
> > An: scm-dev@maven.apache.org
> > Datum: Donnerstag, 15. Januar 2009, 15:33 
> > http://www.mail-archive.com/scm-dev@maven.apache.org/msg01173.html
> > 
> > It seems I wasn't actually subscribed to scm-dev so I 
> didn't' get this 
> > response right away. Thanks for the response Mark.
> > 
> > I have actually tested this and have seen it fail. We have made 
> > modifications to SVN to print out the author differently.
> > I noticed the
> > problem when I tried running the changelog report and got 
> no output.  
> > I was bashing my head on my desk trying to figure out why for the 
> > longest time ;-).
> > 
> > I have also already made the modifications to the 
> > maven-scm-provider-svnexe project and added all appropriate test 
> > cases.
> > My initial plan was to simply store a copy of the source in our svn 
> > repo. However, I now have permission to submit this to the proper 
> > place.
> > 
> > I will raise a JIRA to track the issue and then I would 
> like to submit 
> > a patch for all appropriate personnel to review.  Do I 
> simply attach 
> > an SVN patch to this mailing list?
> > 
> > ---
> > Todd Thiessen
> 
> 
>       
> 

Reply via email to