is it necessary to required svn 1.5?? and break backward compatibility? - cl.createArg().setValue( "--parents" ); + // SCM-487 olamy : this need a svn 1.5 cli + //cl.createArg().setValue( "--parents" );
I hope release plugin would never pick this up -Dan On Mon, Nov 30, 2009 at 3:29 PM, <ol...@apache.org> wrote: > Author: olamy > Date: Mon Nov 30 23:29:16 2009 > New Revision: 885618 > > URL: http://svn.apache.org/viewvc?rev=885618&view=rev > Log: > revert SCM-487 > > Modified: > > maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/main/java/org/apache/maven/scm/provider/svn/svnexe/command/tag/SvnTagCommand.java > > maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/tag/SvnExeTagCommandTckTest.java > > Modified: > maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/main/java/org/apache/maven/scm/provider/svn/svnexe/command/tag/SvnTagCommand.java > URL: > http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/main/java/org/apache/maven/scm/provider/svn/svnexe/command/tag/SvnTagCommand.java?rev=885618&r1=885617&r2=885618&view=diff > ============================================================================== > --- > maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/main/java/org/apache/maven/scm/provider/svn/svnexe/command/tag/SvnTagCommand.java > (original) > +++ > maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/main/java/org/apache/maven/scm/provider/svn/svnexe/command/tag/SvnTagCommand.java > Mon Nov 30 23:29:16 2009 > @@ -230,7 +230,8 @@ > > cl.createArg().setValue( messageFile.getAbsolutePath() ); > > - cl.createArg().setValue( "--parents" ); > + // SCM-487 olamy : this need a svn 1.5 cli > + //cl.createArg().setValue( "--parents" ); > > if ( scmTagParameters != null && scmTagParameters.getScmRevision() != > null ) > { > > Modified: > maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/tag/SvnExeTagCommandTckTest.java > URL: > http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/tag/SvnExeTagCommandTckTest.java?rev=885618&r1=885617&r2=885618&view=diff > ============================================================================== > --- > maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/tag/SvnExeTagCommandTckTest.java > (original) > +++ > maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/tag/SvnExeTagCommandTckTest.java > Mon Nov 30 23:29:16 2009 > @@ -44,7 +44,7 @@ > > testCommandLine( "scm:svn:svn+ssh://foo.com/svn/trunk", "svntag", > messageFile, "user", > "svn --username user --non-interactive copy --file " > + messageFile.getAbsolutePath() + > - " --parents . > svn+ssh://u...@foo.com/svn/tags/svntag", null ); > + " . svn+ssh://u...@foo.com/svn/tags/svntag", > null ); > } > > public void testTagRemoteTagHttps() > @@ -57,7 +57,7 @@ > scmTagParameters.setRemoteTagging( true ); > testCommandLine( "scm:svn:http://foo.com/svn/trunk";, "svntag", > messageFile, "user", > "svn --username user --non-interactive copy --file " > + messageFile.getAbsolutePath() > - + " --parents http://foo.com/svn/trunk > http://foo.com/svn/tags/svntag";, scmTagParameters ); > + + " http://foo.com/svn/trunk > http://foo.com/svn/tags/svntag";, scmTagParameters ); > } > > public void testTagRemoteTagHttpsWithRevision() > @@ -71,7 +71,7 @@ > scmTagParameters.setScmRevision( "12" ); > testCommandLine( "scm:svn:http://foo.com/svn/trunk";, "svntag", > messageFile, "user", > "svn --username user --non-interactive copy --file " > + messageFile.getAbsolutePath() > - + " --parents --revision 12 > http://foo.com/svn/trunk http://foo.com/svn/tags/svntag";, > + + " --revision 12 http://foo.com/svn/trunk > http://foo.com/svn/tags/svntag";, > scmTagParameters ); > } > > > >
